PP bug fix and crash log #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerket
reviewed
May 15, 2020
| @@ -326,6 +326,7 @@ def combine_results(fs, results_dir, cfg, do_timeseries=True): | |||
|
|
|||
| # Determine how many files should be in each partition and group the files | |||
| npartitions = math.ceil(total_mem / 1e9) # 1 GB per partition | |||
| npartitions = min(len(ts_filenames), npartitions) # cannot have less than one file per partition | |||
There was a problem hiding this comment.
Do you have a test for this? To avoid having to make files that are actually big enough to hit this issue, you could mock some function in the line of calculation for total_mem.
There was a problem hiding this comment.
I have added the test.
nmerket
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The postrprocessing would crash if the number of partitions ended up being larger than number of files.
Pull Request Description
The pull request as two part.
Checklist
Not all may apply