Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return elementary dict even when simulations fail #197

Merged
merged 5 commits into from Mar 12, 2021

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Dec 15, 2020

Fixes #196

Pull Request Description

Fix for the bug

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee
Copy link
Contributor Author

rajeee commented Dec 15, 2020

@lixiliu Once this is merged, the kind of error you ran into should be eradicated!

@rajeee rajeee requested a review from nmerket December 15, 2020 17:11
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeee Sorry this took me so long to look at. This looks good. Is there any way we could write a test to exercise this?

@nmerket
Copy link
Member

nmerket commented Jan 12, 2021

Oh, and if you could put a note in the changelog, please.

@nmerket nmerket merged commit 1cd0349 into develop Mar 12, 2021
@nmerket nmerket deleted the failed_sim_bug_fix branch March 12, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postprocessing fails when when a building simulation crashes at BSB
2 participants