Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby installer and remotes #38

Merged
merged 12 commits into from
Jan 18, 2022
Merged

Update ruby installer and remotes #38

merged 12 commits into from
Jan 18, 2022

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jan 6, 2022

No description provided.

@jmarrec jmarrec requested a review from tijcolem January 6, 2022 13:04
@jmarrec jmarrec self-assigned this Jan 6, 2022
@jmarrec jmarrec force-pushed the update_ruby_installer_and_remotes branch from fb89db7 to dfda99f Compare January 7, 2022 17:15
@jmarrec jmarrec force-pushed the update_ruby_installer_and_remotes branch from dfda99f to 92c45f9 Compare January 7, 2022 17:23
@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 12, 2022 •
edited

I have no clue why Github actions is hanging like this on MSVC ?! It works just fine locally

@macumber
Copy link

There is a warning saying "The windows-2016 environment is deprecated and will be removed on March 15, 2022. Migrate to windows-latest instead. For more details see actions/runner-images#4312" that is possibly related?

I see you tried re-running once, maybe you could try re-running again in case this brownout was the issue?

https://twitter.com/github/status/1420097157885988867?lang=en

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 14, 2022

The release build is working fine.
It's the DEBUG one that hangs at "generating parse.c". I hadn't tried Debug locally, will do.

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 14, 2022

Ah, there you go:

Screen Shot 2022-01-14 at 13 35 48

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 14, 2022

This is likely due to the fact that I uploaded a new version (recipe revision) of the bison/3.7.1 package on NREL's artifactory.

This new one fails: https://conan.commercialbuildings.dev/ui/repos/tree/General/openstudio%2F_%2Fbison%2F3.7.1%2F_%2F8bba3cd5416cf47dbc99130108ecb67e

If I pin it exactly to the former one, it works: ad29e804e82c8b6d58765096676b5a5e

...

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 14, 2022

THe bottom line is that the old bison revision uses m4/1.4.18 and the new one uses m4/1.4.19. So something changed there

tijcolem
tijcolem approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@tijcolem tijcolem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll sit on MSVC 2022 for now.

@tijcolem tijcolem merged commit 7f0d72b into master Jan 18, 2022
@tijcolem tijcolem deleted the update_ruby_installer_and_remotes branch January 18, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijcolem tijcolem tijcolem approved these changes

Assignees

@jmarrec jmarrec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmarrec @macumber @tijcolem