fastsimrust is now a submodule of fastsim #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this solves various module not found issues and is consistent with altrios.
deprecated `RUST_AVAILABLE` and `rustext`
|
@nreinicke, could I ask you to take a look at the failing tests for this PR? I'm unable to reproduce the error on my end and very baffled by the discrepancy. |
…stall-fix # Conflicts: # README.md # python/fastsim/demos/output.html
…st as fsr` to check if this works on server
…astsimrust as fsr` to check if this works on server" This reverts commit 734b72c.
|
@calbaker - What's your definition of done here? I was hitting the same error locally using pytest and so I just switched over to using the unittest library and everything is working. Is there a specific reason you need to use pytest to run the test suite? Of note: I could get pytest to work when installing the rust extension in a develop mode (either |
|
@calbaker - FYI - looks like using a dev install with pytest works fine on the server. |
kylecarow
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this solves various module not found issues
and is consistent with altrios.
Made it so that tests don't need any dev dependencies.