Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Unexpected behavior in SerialRefine caused by quiet NaNs #605

Merged
merged 6 commits into from
Mar 17, 2023
Merged

Bugfix: Unexpected behavior in SerialRefine caused by quiet NaNs #605

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a11109
Change argmax to nanargmax
paulf81 Mar 13, 2023
045f8d0
Add test example
paulf81 Mar 13, 2023
e5957dd
Add nan warning
paulf81 Mar 13, 2023
8c2ca11
Updating warning message handling, removing temporary example.
Mar 16, 2023
afd57dc
Cleaning up trailing whitespace as suggested by pre-commit.
Mar 17, 2023
ea991f9
Remove unused import
rafmudaf Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions floris/tools/optimization/yaw_optimization/yaw_optimizer_sr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
import numpy as np
import pandas as pd

from floris.logging_manager import LoggerBase

# from .yaw_optimizer_scipy import YawOptimizationScipy
from .yaw_optimization_base import YawOptimization


class YawOptimizationSR(YawOptimization):
class YawOptimizationSR(YawOptimization, LoggerBase):
def __init__(
self,
fi,
Expand Down Expand Up @@ -240,8 +242,17 @@ def optimize(self, print_progress=True):
# Evaluate grid of yaw angles, get farm powers and find optimal solutions
farm_powers = self._process_evaluation_grid()

# If farm powers contains any nans, then issue a warning
if np.any(np.isnan(farm_powers)):
err_msg = (
"NaNs found in farm powers during SerialRefine "
"optimization routine. Proceeding to maximize over yaw "
"settings that produce valid powers."
)
self.logger.warning(err_msg, stack_info=True)

# Find optimal solutions in new evaluation grid
args_opt = np.expand_dims(np.argmax(farm_powers, axis=0), axis=0)
args_opt = np.expand_dims(np.nanargmax(farm_powers, axis=0), axis=0)
farm_powers_opt_new = np.squeeze(
np.take_along_axis(farm_powers, args_opt, axis=0),
axis=0,
Expand Down