Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Empirical Gauss wake model for fitting SCADA data #628

Merged
merged 140 commits into from May 10, 2023

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Apr 22, 2023

This pull request is to incorporate the new Empirical Gaussian wake model (working name Geometric Model).

This PR includes:

  • The new parametrization of the Gaussian wake model designed to be simpler to tune and more flexible for fitting observed wind farm data, consisting of
    • a new velocity deficit model
    • a new velocity deflection model
    • a new "wake induced mixing" model to replace wake-added turbulence
  • Vertical wake deflections due to rotor tilt
  • Mirror wakes to address stumpiness and ground effects

TO DO before merge:

  • Add example to demonstrate usage of empirical_gauss model
  • Check default tuning, ensure defaults match the example input file emgauss.yaml
  • Check documentation in docs/empirical_gauss_model.md and develop docstrings for new functions, classes, and methods
  • Check/update current tests,
  • Develop regression tests

NOT included in this PR, but for possible future developments:

  • Implement unit tests for lower-level functions as part of the simulation tools, e.g. sigmoid_integral
  • Profile code and look for speed-up opportunities

misi9170 and others added 30 commits October 26, 2022 06:26
…ctionality; apply tilt correction to poewr calculation;
…t passed out to anywhere else in the code.
@rafmudaf rafmudaf force-pushed the feature/geomod branch 3 times, most recently from e7e7027 to 9fa4398 Compare May 8, 2023 21:38
@rafmudaf rafmudaf added the enhancement An improvement of an existing feature label May 8, 2023
@rafmudaf
Copy link
Collaborator

rafmudaf commented May 8, 2023

@misi9170 I made a few syntax and style changes in the last few commits. There's nothing fundamentally different and the tests pass, but I think you should review them just in case. Otherwise, this looks great. Thanks for making it easy to review and good work!

@rafmudaf rafmudaf changed the title New wake model for fitting SCADA data Add Empirical Gauss wake model for fitting SCADA data May 8, 2023
@misi9170
Copy link
Collaborator Author

misi9170 commented May 8, 2023

@misi9170 I made a few syntax and style changes in the last few commits. There's nothing fundamentally different and the tests pass, but I think you should review them just in case. Otherwise, this looks great. Thanks for making it easy to review and good work!

@rafmudaf Thanks! I just looked at the diffs for the last five or so of your commits and everything looks good to me.

@rafmudaf rafmudaf merged commit ebd70ec into NREL:develop May 10, 2023
5 checks passed
@rafmudaf rafmudaf mentioned this pull request May 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants