Docs: Update timing tests with results from Eagle #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the current code quality page shows a slow down in performance for the last commit plotted. After running this on Eagle, we see that this drop in performance is not accurate and was likely due to running this on a laptop. Maybe I moved the mouse and it took up some compute cycles. Eagle provides a much more stable environment for these types of tests. |
|
Hey @paulf81 just a reminder to double check that all the relevant context is included here before we merge |
|
Looks great and thanks a lot for doing this @rafmudaf , it is really great check to be able to run that can help us look backward and assess future commits impact on performance |
paulf81
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Eagle for performance tests
This pull request updates the Code Quality page with timing results from Eagle rather than my laptop.
Related issue
None
Impacted areas of the software
Code Quality documentation page only.
Additional supporting information
This script to create this data is available in my floris_metrics repo. It is not yet automated but it's on my radar to somehow include this in the CI or a nightly or weekly script.