Add CI branch for Python 3.8 and 3.10, update Ruff #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintains a test with 3.9 for the unit tests
|
nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand CI coverage to include Python 3.8, 3.9, and 3.10
This pull request adds two more Python versions, 3.8 and 3.10, to the test matrix in addition to Python 3.9 for the automated testing GitHub Actions workflow that runs the unit tests, regression tests, and code coverage script. For the other GitHub Actions workflows, the Python version is upgraded to Python 3.10 from 3.9.
The motivation for this change is that we technically support these three versions of Python but we rarely actually use them. Most of the NREL team is on 3.9 or 3.10. Rather than installing 3.8 periodically to check, I prefer to offload this to the CI.
Upgrade Ruff adherence to v0.0.265
Lastly, formatting is fixed to support the latest version of Ruff, v0.0.265, but the minimum required version is not pinned.
Related issue
No open issue.
Impacted areas of the software
Formatting changes in some files, but otherwise this only impacts GitHub Actions configuration.