Bug fix: Add variable wind shear to GCH calculations #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafmudaf
approved these changes
Jul 10, 2023
|
Thanks for tackling this @fg320. Well done describing the issue and submitting the fix. We very much appreciate it! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variable wind shear to GCH calculations
This pull request addresses the issue in #675. The calculations for the GCH model do not account for variable wind shear and are fixed to a shear coefficient of 0.12. Specifically, this is found in the
vel_topandvel_bottomcalculations in methodswake_added_yawandcalculate_transverse_velocity. A new input argumentwind_shear, which is extracted from theFlowFieldobject (flow_field.wind_shear), is now added to the above-mentioned methods and included in the calculations.Related issue
Issue #675Impacted areas of the software
floris/simulation/solver.pyfloris/simulation/wake_deflection/gauss.py