Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in notebooks for online documentation #721

Merged
merged 2 commits into from Nov 15, 2023

Conversation

rctredgold
Copy link
Contributor

@rctredgold rctredgold commented Oct 22, 2023

Fixes broken code cell in intro notebook

This pull request fixes a broken code cell in the Background and Concepts documentation page. It incorrectly refers to grid.x, but this variable was removed in #578.

Related issue

#733

Impacted areas of the software

Background and Concepts documentation

@rctredgold rctredgold closed this Oct 22, 2023
@rafmudaf rafmudaf reopened this Nov 8, 2023
@rafmudaf rafmudaf changed the title Update floris_101.ipynb Fix errors in FLORIS 101 notebook Nov 8, 2023
@rafmudaf rafmudaf changed the base branch from main to develop November 8, 2023 19:58
@rafmudaf rafmudaf self-assigned this Nov 8, 2023
@rafmudaf rafmudaf added bug Something isn't working documentation labels Nov 8, 2023
@rafmudaf rafmudaf added this to the v3.6 milestone Nov 8, 2023
@rafmudaf
Copy link
Collaborator

rafmudaf commented Nov 8, 2023

This pull request is related to #378.

@rafmudaf rafmudaf changed the title Fix errors in FLORIS 101 notebook Fix errors in notebooks for online documentation Nov 8, 2023
@rafmudaf rafmudaf mentioned this pull request Nov 8, 2023
4 tasks
@rafmudaf rafmudaf self-requested a review November 15, 2023 21:45
@rafmudaf rafmudaf merged commit bc4fd28 into NREL:develop Nov 15, 2023
5 of 8 checks passed
@rafmudaf
Copy link
Collaborator

Thanks for creating this pull request @rctredgold!

@misi9170 misi9170 mentioned this pull request Apr 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants