Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from Apache to BSD 3-clause license #810

Merged
merged 8 commits into from Feb 21, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Feb 19, 2024

Change from Apache to BSD license

This pull request starts the process of switching from APACHE to BSD license. Specifically the 3-clause BSD license as used in OpenOA So far:

@paulf81 paulf81 added the v4 Focus of FLORIS v4 label Feb 19, 2024
@paulf81 paulf81 added this to the v4.0 milestone Feb 19, 2024
@paulf81 paulf81 self-assigned this Feb 19, 2024
@RHammond2
Copy link
Collaborator

@paulf81, this is something that might be required of some specific licenses (definitely not the BSD 3 Clause though), but is generally a relic of old practices. You can certainly add the license to each file if you feel that would be helpful to users making new models/code from FLORIS, but it's not at all required.

@paulf81
Copy link
Collaborator Author

paulf81 commented Feb 20, 2024

@paulf81, this is something that might be required of some specific licenses (definitely not the BSD 3 Clause though), but is generally a relic of old practices. You can certainly add the license to each file if you feel that would be helpful to users making new models/code from FLORIS, but it's not at all required.

Thank you @RHammond2 !

@paulf81 paulf81 marked this pull request as ready for review February 20, 2024 21:46
@paulf81
Copy link
Collaborator Author

paulf81 commented Feb 20, 2024

@rafmudaf and @misi9170 this is ready for review

LICENSE.txt Outdated Show resolved Hide resolved
@rafmudaf
Copy link
Collaborator

For module files and scripts, I think we should commit to the convention of having one blank line at the beginning of the file, then any imports, and then multiline comments:

import this
import that

"""
This is what this example does...
"""

fi = FlorisInterface("file")
fi.many_wind_energies()

@paulf81 if you agree, I'll make these changes.

@paulf81
Copy link
Collaborator Author

paulf81 commented Feb 20, 2024

For module files and scripts, I think we should commit to the convention of having one blank line at the beginning of the file, then any imports, and then multiline comments:

import this
import that

"""
This is what this example does...
"""

fi = FlorisInterface("file")
fi.many_wind_energies()

@paulf81 if you agree, I'll make these changes.

Sounds great to me @rafmudaf thank you

@rafmudaf rafmudaf self-requested a review February 21, 2024 00:49
@rafmudaf rafmudaf changed the title Change from Apache to BSD license Change from Apache to BSD 3-clause license Feb 21, 2024
@rafmudaf rafmudaf merged commit 37f336e into NREL:v4 Feb 21, 2024
8 checks passed
@paulf81 paulf81 deleted the feature/update_to_bsd_license branch February 21, 2024 17:53
@misi9170 misi9170 mentioned this pull request Apr 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Focus of FLORIS v4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants