Support multidimensional turbine definitions in all wake models #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafmudaf
approved these changes
Feb 21, 2024
# Conflicts: # tests/reg_tests/floris_interface_regression_test.py
rafmudaf
approved these changes
Feb 22, 2024
rafmudaf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multidimensional wind turbines were introduced in #711, a specific solver was set up to handle the different multidimensional turbine models (
sequential_multidim_solver()on solver.py). In #770, the need for a separate turbine model to handle multidimensional Cp/Ct curves was removed; and the specific solver was removed but compatibility was only transferred to thesequential_solver()(see the Further discussion needed section of #770).This PR completes the process of removing the specific velocity model
"mutlidim_cp_ct"and enables compatibility of multidimensional turbine models with all solvers (sequential_solver(),cc_solver(),emgauss_solver(), andturbopark_solver()). Additionally, mutlidimensional compatibility is added to the existingfull_flowsolvers).This also adds regression tests for the full flow solver for each wake model.