Remove unused code from floris.tools and add tool reg tests #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayc
added
enhancement
bayc
force-pushed
the
remove_unused_tools_code
branch
from
b1a8344
to
c6de7fe
Compare
rafmudaf
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Just double checking that we want to remove this from the examples since, currently, this function as the user documentation. If you're planning to add it back, is this captured somewhere so that it doesn't fall off the list of things to document?
There was a problem hiding this comment.
My understanding is that the new wind data functionality replaces this functionality, and is covered in example 34. When the examples are processed, that would be a good time to bring it back into the documentation.
rafmudaf
reviewed
Feb 22, 2024
bayc
force-pushed
the
remove_unused_tools_code
branch
from
d04572f
to
9a7f3bb
Compare
rafmudaf
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up tools and add tool reg tests
This PR removes unused code from the
floris.toolsdirectory, and adds some simple reg tests for the yaw and layout optimization tools.Related issue
None.
Impacted areas of the software
floris.toolstests/reg_testsAdditional supporting information
None.
Test results, if applicable
Passing.