Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change power_thrust_model key to operation_model at the user level #859

Merged
merged 1 commit into from Apr 2, 2024

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Apr 1, 2024

There was a discrepancy between the term used for the turbine operation models at the user level (in turbine yamls and in getter and setters on FlorisModel), which was power_thrust_model, and the term "operation model" that we use in descriptions and throughout the code.

This PR fixes that discrepancy by renaming power_thrust_model to operation_model at the user level.

@misi9170 misi9170 added bug Something isn't working v4 Focus of FLORIS v4 labels Apr 1, 2024
@misi9170 misi9170 added this to the v4.0 milestone Apr 1, 2024
@misi9170 misi9170 merged commit 614cffe into NREL:v4 Apr 2, 2024
8 checks passed
@misi9170 misi9170 deleted the v4-ms/operation_model-key branch April 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4 Focus of FLORIS v4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants