Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setpoints and wind condition specifics from calculate_XX_plane methods #868

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Remove setpoints and wind condition specifics from calculate_XX_plane methods #868

merged 12 commits into from
Apr 8, 2024

Commits on Apr 5, 2024

  1. remove yaw angles argument; switch to deepcopies.

    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9ee9cf2 View commit details
    Browse the repository at this point in the history

  2. No longer allowed to pass wd, ws, ti---instead, specify a findex (or … 

    …set a single ws, wd, ti).
    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d617001 View commit details
    Browse the repository at this point in the history

  3. Remove erroneous type hints.

    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c9837df View commit details
    Browse the repository at this point in the history

  4. update tests.

    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fdf212d View commit details
    Browse the repository at this point in the history

  5. Ruff formatting.

    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e4f28bd View commit details
    Browse the repository at this point in the history

  6. Update examples. Note that previous calculate_XX_planes altered the r… 

    …otor_diameters field on fmodel.
    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    545768a View commit details
    Browse the repository at this point in the history

  7. Merging v4, resolving conflicts.

    @misi9170
    misi9170 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6694c2d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Merge v4.

    @misi9170
    misi9170 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    e51a5e0 View commit details
    Browse the repository at this point in the history

  2. Update Helix viz.

    @misi9170
    misi9170 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    378777c View commit details
    Browse the repository at this point in the history

  3. calculate_horizontal_plane_with_turbines now consistent with calculat… 

    …e_horizontal_plane.
    @misi9170
    misi9170 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6ccb27d View commit details
    Browse the repository at this point in the history

  4. remove now-redundant check_wind_condition_for_viz

    @misi9170
    misi9170 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    f99914c View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Clean up TODOs and docstrings.

    @misi9170
    misi9170 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    94d2c2b View commit details
    Browse the repository at this point in the history