-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pandas dependency by decoupling csv writing from dataframes #176
Conversation
This is finally passing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I love that we can not depend on pandas for the core simulator; left a small comment
nrel/hive/app/run_batch.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to bring this back since we supply a command line tool that uses it:
Line 60 in a15b8ba
hive-batch = "nrel.hive.app.run_batch:run" |
But, this doesn't use pandas so hopefully that's a trivial ask.
Removes all dependencies on
pandas
, which was mostly being used to write CSVs.At the moment, there's no tests to see if it's producing the same CSVs as before.
Also removes two
run_...
files which were not in active use.