Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bugfix" #28

Closed
wants to merge 1 commit into from
Closed

Revert "Bugfix" #28

wants to merge 1 commit into from

Conversation

bpark1327
Copy link
Collaborator

No description provided.

@bpark1327 bpark1327 closed this May 13, 2021
@shorowit
Copy link
Collaborator

@bpark1327 What was this about?

@bpark1327
Copy link
Collaborator Author

bpark1327 commented May 13, 2021

While I tested the translator with the hescore-hpxml hpxmls, I found a bug in the translation of "AdjacentTo" of the foundation walls. I accidentally reverted this PR. For some reason, if I revert this PR, I thought it would reopen this PR and I could fix the foundation wall bug in this PR. But I realized reverting this PR wouldn't make sense. So I closed it right after.

@bpark1327 bpark1327 deleted the revert-24-bugfix branch May 13, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants