Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #54 #55

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fixes #54 #55

merged 2 commits into from
Oct 18, 2021

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Oct 18, 2021

Fixes #54.

@shorowit shorowit added the bug Something isn't working label Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Oct 18, 2021

File Coverage Missing
All files 98%
__init__.py 100%
converter.py 98% 194, 247, 335, 474-475, 695-696
exceptions.py 100%

Minimum allowed coverage is 95%

Generated by 🐒 cobertura-action against 479dc61

@shorowit
Copy link
Collaborator Author

@bpark1327 Can you add/update tests to cover this situation?

@bpark1327
Copy link
Collaborator

@bpark1327 Can you add/update tests to cover this situation?

I will do.

@bpark1327
Copy link
Collaborator

@shorowit I updated the test file to cover this situation. If a Wall element ends up with more than 1 AtticWallType child element, the translator will raise the validation error. So, I think there is no need to add an assertion in the test.

@shorowit
Copy link
Collaborator Author

Thanks @bpark1327. I verified that if I manually remove my bugfix, your new test will fail. So it looks good to me.

@shorowit shorowit merged commit fc4a305 into main Oct 18, 2021
@shorowit shorowit deleted the fix_duplicate_attic_wall_type branch October 18, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate AtticWallType elements in resulting HPXML
2 participants