Add msgpack gem (not cbor) to the CLI #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
enhancement
jmarrec
added a commit
to NREL/OpenStudio
that referenced
this pull request
Nov 16, 2021
…on OpenStudio's side
jmarrec
force-pushed
the
4496_Add_cbor_gem
branch
from
1efadc7
to
09bab57
Compare
19 tasks
jmarrec
commented
Nov 16, 2021
Gemfile
Outdated
Comment on lines
25
to
26
| gem 'cbor', '0.5.9.6' | ||
| gem 'msgpack', '1.4.2' |
There was a problem hiding this comment.
Add cbor and msgpack
Comment on lines
+160
to
+162
| File.open("#{install_dir}/version.txt", 'w') do |f| | ||
| f.puts new_file_name | ||
| end |
There was a problem hiding this comment.
Write the tar.gz name into a text file at the root of the extracted dir, so we can get it from CMake to ensure we always use the right version when switching branches: checking that we have the .tar.gz locally and it has the right MD5sum doesn't suffice to tell that the extracted directory is the right now, as you may have multiple openstudio3-gems tar.gzs.
Comment on lines
+172
to
+192
| puts "Also, you will need to update OpenStudio/CMakeLists.txt with the new file name and the md5 hash (call `md5 #{new_file_name}` or `md5sum #{new_file_name}` to get hash)" | ||
| puts | ||
| cmd = nil | ||
| if platform_prefix == 'Windows' | ||
| cmd = "certutil -hashfile \"#{new_file_name}\" MD5" | ||
| else | ||
| cmd = "md5sum \"#{new_file_name}\"" | ||
| end | ||
|
|
||
| Open3.popen3(cmd) do |stdin, stdout, stderr, wait_thr| | ||
| stdout = stdout.gets(nil) | ||
| stderr = stderr.gets(nil) | ||
| result = wait_thr.value.exitstatus | ||
| if result == 0 | ||
| puts "#{stdout}" | ||
| else | ||
| puts "Something went wrong, exitcode=#{result}" | ||
| puts "stdout=#{stdout}" | ||
| puts "stderr=#{stderr}" | ||
| end | ||
| end |
There was a problem hiding this comment.
Bake the md5sum spit out into the rake make_package for convenience when building locally
jmarrec
changed the title
tijcolem
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently no patch needed to make it work with MSVC (tested locally)