Implement new workflow to search constructions. #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new workflow added a new method called model_get_percent_of_surface_range, and it enables flexibility in identify construction based on window to wall ratio by adding two search criteria: minimum_percent_of_surface and max_percent_of_surface. The default behavior of this function returns nil for both min&max percent of surface. The detail implementation shall be overriden in the each individual routine (90.1-2004 for example). Add 90.1-2004 to test_small_office test set.
…into OSSTD266-ExteriorWindowLookupFor9012004
lymereJ
reviewed
Jan 18, 2022
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| class TestSmallOffice < CreateDOEPrototypeBuildingTest | |||
| building_types = ['SmallOffice'] | |||
| templates = ['DOE Ref Pre-1980','DOE Ref 1980-2004','90.1-2007','90.1-2013','90.1-2016','90.1-2019'] | |||
| templates = ['DOE Ref Pre-1980','DOE Ref 1980-2004','90.1-2004','90.1-2007','90.1-2013','90.1-2016','90.1-2019'] | |||
There was a problem hiding this comment.
Let's maybe remove 90.1-2004 from the list so templates is consistent with the other building types.
There was a problem hiding this comment.
90.1-2004 is removed.
lymereJ
approved these changes
Jan 18, 2022
…d of 0. Fix the issue and repost for CI
mdahlhausen
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction search in 90.1-2004 depends on min & max percent of surface.
The fix introduces a new workflow that added a new method called model_get_percent_of_surface_range, and it enables flexibility in identifying construction based on window to wall ratio by adding two search criteria: minimum_percent_of_surface and max_percent_of_surface.
The default behavior of this function returns nil for both min&max percent of surface. The detail implementation shall be overriden in the each individual routine (90.1-2004).
Add 90.1-2004 to test_small_office test set.
Tests has run locally for All ASHRAE prototype & baseline.