Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change constant ruleset value checking #1304

Merged
merged 2 commits into from Apr 16, 2022
Merged

change constant ruleset value checking #1304

merged 2 commits into from Apr 16, 2022

Conversation

mdahlhausen
Copy link
Collaborator

change existing schedule value check from an exact comparison to within a small tolerance

addresses issue #1119

change existing schedule value check from an exact comparison to within a small tolerance
@mdahlhausen
Copy link
Collaborator Author

@lymereJ this pull requests adds a tolerance value check instead of equality check when adding constant ruleset schedules. It prevents adding duplicate copies identical of constant day schedules like 'Mixed Water At Faucet Temp - 140F Default 17' which are prolific throughout the prototypes. Currently the model regression tests are failing because the duplicate schedules aren't generated. Could you regenerate the regression models?

@lymereJ
Copy link
Collaborator

lymereJ commented Apr 15, 2022

@mdahlhausen - I just uploaded them.

@mdahlhausen
Copy link
Collaborator Author

@lymereJ thanks!

@mdahlhausen mdahlhausen merged commit 8f4f6f9 into master Apr 16, 2022
@mdahlhausen mdahlhausen deleted the fix/issue1119 branch April 16, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants