Merging changes from master branch and updating regression tests run with OS 3.5.1 #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update regression and performance test results
improve logging for missing standards space type
Fixes #238 If there is no infiltration data, then space_type_apply_internal_loads would return nil instead of true. This makes sure that even if there is no infiltration, the method will return true if it ran successfully.
Fixes #109, checking hard-sized values before autosized values anywhere size checking appears in the code.
add return true to end of apply internal loads
check hard-sized values before autosized values
Add version reference for initialization summary
…into appx_debug
The building had mismatched surfaces. Divided the surface geometry and re-applied surface matching.
Appx debug
Fix/os351
the tall building methods delete some stories dynamically depending on the ratio of floor types (e.g. one floor might be retail). Deleting a space will not chance the surface adjacencies in adjacent spaces, which will still show surface adjacencies. This causes an error in the add constructions methods, which try to set plenum constructions for the ceiling if the adjacent space is a plenum. As there was no adjacent space, the get method errored out.
skylight frame setter was fixed; add version toggle and use new method
parking garage is not a supported space type
fix skylight assignment
intersect and surface match
still fails in secondary lighting type - possibly related to the polygon join issue.
Fix/o sv360rc1
test updates
Fix/o sv360rc1
fixes a bug with the tbd gem dependency for developers using 0.3.1
90.1-2016 and 90.1-2019 PTHP systems don't use the pthp_cop_coefficient_1, pthp_cop_coefficient_2 coefficients as earlier versions. Add a check that they are present for earlier standards.
check PTHP cop coefficients
fix for Issue 1502
Commenting out NRCan development gems.
Commenting out NRCan only development Gem require statements.
Including ability to not apply daylighting by setting "daylighting_type" to none.
* Add json file for compressor type of air cooled chiller for ECM HS14 * Add water cooled chiller type json for NECB and update name of chiller based on compressor type * Update initial name of water-cooled chiller in ECM HS14 Set name of 'Screw' chillers to 'Rotary Screw' Set default 'chiller_type' in file 'fuel_type_sets.json' to empty. In this case chiller type is set based on information in new file 'chiller_types.json'. Update standard method for setting efficiency and curves of water cooled electric chillers to deal with the situation when the chiller name doesn't have information on the chiller type. If the name doesn't have information on the chiller type then this will be set based on information from the new file 'chiller_types.json'. Modify method in class 'BTAPPRE1980' to modify name of chiller when the original name doesn't include a compressor type Update building regression tests osm files --------- Co-authored-by: khaddad <khaddad.energy.eng@gmail.com>
…th regression test results using OS 3.5.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.