add exterior lighting test function #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorganize the exterio lighting function to split the user data reading from the PRM data setting.
lymereJ
reviewed
Aug 4, 2023
| # Update existing exterior lights object: control, schedule, power | ||
| ext_lights_obj.setControlOption('AstronomicalClock') | ||
| ext_lights_obj.setSchedule(model.alwaysOnDiscreteSchedule) | ||
| ext_lights_obj.setMultiplier(1) | ||
| ext_lights_def = ext_lights_obj.exteriorLightsDefinition | ||
| ext_lights_def.setDesignLevel(ext_ltg_pwr) | ||
| ext_ltg_pwr = get_additional_property_as_double(ext_lights_obj, 'design_level', 0.0) | ||
| if ext_ltg_pwr > 0.0 |
There was a problem hiding this comment.
Is there a chance that ext_ltg_pwr be 0? If so, should this be greater or equal to?
There was a problem hiding this comment.
You are correct. it seems the ext_ltg_pwr is well protected from all the functions to be sure it is handled as 0.0 when failed.
In that case, we assume 0.0 and issue a warning. I will add these pieces in the code.
lymereJ
approved these changes
Aug 4, 2023
…andards into appx_g/enhancement/apply_baseline_exterior_lighting # Conflicts: # lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb
weilixu
deleted the
appx_g/enhancement/apply_baseline_exterior_lighting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganize the exterio lighting function to split the user data reading from the PRM data setting.