Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed model #1556

Merged
merged 23 commits into from
Sep 15, 2023
Merged

Proposed model #1556

merged 23 commits into from
Sep 15, 2023

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Aug 8, 2023

The proposed changes add the capability to generate a proposed building model from a user model in addition to the baseline model following the ASHRAE Standard 90.1-Appendix G rules.

…pendix G automation. Add a first draft of the removal of indoor and outdoor SWH pipes in the proposed model.
@lymereJ lymereJ added the AppendixG Methods to enable the Appendix G model workflow label Aug 8, 2023
@lymereJ lymereJ changed the base branch from master to AppendixG_Dev August 8, 2023 05:14
@lymereJ lymereJ marked this pull request as ready for review September 15, 2023 15:41
Copy link
Collaborator

@weilixu weilixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.
One comment about the warning message.

lib/openstudio-standards/standards/Standards.Model.rb Outdated Show resolved Hide resolved
@weilixu weilixu merged commit 4c69c45 into AppendixG_Dev Sep 15, 2023
0 of 2 checks passed
@weilixu weilixu mentioned this pull request Sep 22, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants