Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRF outdoor unit max_net_vert_distance calculation #1557

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented Aug 8, 2023

background

  • noticed there is a line like this below when calculating Vertical Height used for Piping Correction Factor for AirConditioner:VariableRefrigerantFlow object

    max_net_vert_distance = [max_net_vert_distance, 0.000001].max
    
  • which was not letting max_net_vert_distance to be a negative value

  • but EP documentation example shows max_net_vert_distance can be a negative value. for example, if your VRF outdoor unit is located on the roof, and all of your indoor units are below the roof, max_net_vert_distance becomes a negative value.

change summary

  • so this change is basically removing one line.

  • cc-ing: @khaddad

@mdahlhausen
Copy link
Collaborator

check if the value can be zero. if so, remove the check

@JanghyunJK
Copy link
Contributor Author

JanghyunJK commented Aug 8, 2023

did a test by varying max_net_vert_distance from -50 to 50 meters (and including zero) for the same model and looks like setting max_net_vert_distance to zero does not throw any error. so, removing the if statement for zero.

image

@JanghyunJK JanghyunJK self-assigned this Aug 8, 2023
@mdahlhausen
Copy link
Collaborator

cool. I'll wait for the tests to run then merge asap.

@mdahlhausen mdahlhausen merged commit 714437e into master Aug 9, 2023
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the vrf-ou-vertical-height branch August 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants