Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deer ventilation rates #1558

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Deer ventilation rates #1558

merged 9 commits into from
Aug 9, 2023

Conversation

amylebar
Copy link
Contributor

@amylebar amylebar commented Aug 8, 2023

Add DCV functionality to DEER standards based on California Title 24 code years

  • Create ThermalZone.rb and AirLoopHVAC.rb for relevant CA T24 code years
  • Add requirements for these new .rb scripts in openstudio-standards.rb

amylebar and others added 6 commits February 13, 2023 08:19
- Add "air_loop_hvac_demand_control_ventilation_limits" method to deer.AirLoopHVAC.rb
- Add minimum floor area to applicable DEER templates in ThermalZone.rb
# Conflicts:
#	lib/openstudio-standards/standards/deer/deer.AirLoopHVAC.rb
#	lib/openstudio-standards/standards/deer/deer_2003/deer_2003.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2007/deer_2007.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2011/deer_2011.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2014/deer_2014.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2015/deer_2015.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2017/deer_2017.ThermalZone.rb
#	lib/openstudio-standards/standards/deer/deer_2020/deer_2020.AirLoopHVAC.rb
#	lib/openstudio-standards/standards/deer/deer_2020/deer_2020.ThermalZone.rb
- added `require_relative` for DEER code year files, such as ThermalZone and AirLoopHVAC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include .vscode artifacts

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; I can merge after it finishes the CI tests with no major errors.

@mdahlhausen mdahlhausen merged commit 94243bb into master Aug 9, 2023
@mdahlhausen mdahlhausen deleted the deer_ventilation_rates branch August 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants