remove VRP default in VAV constructor #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes model_system_outdoor_air_sizing_vrp_method(air_loop) and air_loop_hvac_apply_vav_damper_action(air_loop) methods from the default constructor for VAV systems. Instead, default to ZoneSum for the controller mechanical ventilation, and single maximum for VAV reheat terminals. Still apply these methods before the sizing run in the create PRM baseline and create prototype methods. Also, harmonize the outdoor air system setup between the VAV and PVAV archetypes.
|
@lymereJ could you review this too? There should (hopefully) be no impact on the PRM methods. |
lymereJ
reviewed
Aug 9, 2023
| @@ -3249,7 +3249,7 @@ def model_add_crac(model, | |||
| fan.setAvailabilitySchedule(hvac_op_sch) | |||
| else | |||
| OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', "Fan type '#{fan_type}' not recognized, cannot add CRAC.") | |||
| return [] | |||
| return false | |||
There was a problem hiding this comment.
Looks like YARD comment for return should be updated.
There was a problem hiding this comment.
it's behind an error message, so the return type doesn't really matter. I'm aligning with the rest of the to return false after an error.
lymereJ
approved these changes
Aug 9, 2023
may change to ventilation eventually
|
Thanks for the review @lymereJ! Looks like there are a few prototype regression changes, but no PRM test failures. |
we anticipated it was placed in the wrong place, but it's changing the performance results.
…est-reporters v1.6.1.
Removing aws-sdk-s3 and git-revision gems not used in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes model_system_outdoor_air_sizing_vrp_method(air_loop) and air_loop_hvac_apply_vav_damper_action(air_loop) methods from the default constructor for VAV systems. Instead, default to ZoneSum for the controller mechanical ventilation, and single maximum for VAV reheat terminals. Still apply these methods before the sizing run in the create PRM baseline and create prototype methods.
Also, harmonize the outdoor air system setup between the VAV and PVAV archetypes.
Because of some slight name changes, there may be some adjustments to the regression models, though the performance results should not have changed.