Feature/radiant controls zone occupancy

[carlosduarteroa]

Adds support for using specific zone occupancy schedules for radiant control. #1539

[mdahlhausen]

Looks good; please adjust the test helper method and add tests for this in test_radiant_controls.rb

[mdahlhausen]

I recommend implementing this with EnergyManagementSystemSensor on the Schedule value, like you have for the temperature setpoint schedules.

Use the schedule value to determine the control, rather than IF ((CurrentTime >= #{zone_occ_hr_start_name}) && (CurrentTime <= #{zone_occ_hr_end_name})),

That would mean changing it so if occupancy control isn't defined, and instead you get starting/stopping hours, making a ruleset schedule that has those hours and then following that schedule value for control.

To summarize:

1. create an on/off schedule from the zone occupancy schedule
2. if not zone control, create the on/off schedule from the provided start/stop times
3. track that zone schedule with a schedule_value EMS sensor
4. update the logic to check against the sensor value, rather than using IF ((CurrentTime >= #{zone_occ_hr_start_name}) && (CurrentTime <= #{zone_occ_hr_end_name})),

[mdahlhausen]

• Use thermal_zone_get_occupancy_schedule(zone, sch_name, occupied_percentage_threshold) to make an on/off schedule
• name it "#{zone.name} Radiant System Control Schedule"
• add occupied_percentage_threshold argument to radiant controls method, and pass into thermal_zone_get_occupancy_schedule
• use the schedule value to control the system

[mdahlhausen]

Example to create new ScheduleRuleset

econ_max_100_pct_oa_sch = OpenStudio::Model::ScheduleRuleset.new(model)
econ_max_100_pct_oa_sch.setName('Economizer Max OA Fraction 100 pct')
econ_max_100_pct_oa_sch.defaultDaySchedule.setName('Economizer Max OA Fraction 100 pct Default')
econ_max_100_pct_oa_sch.defaultDaySchedule.addValue(OpenStudio::Time.new(0, 24, 0, 0), 1.0)

[carlosduarteroa]

I've made the changes you suggested with commit 54dd618 and b471c4a

[mdahlhausen]

I made a few changes (so pull again) and proposed a different method that is more closely tied to the zone occupancy schedule - and allows much more schedule variation.

[mdahlhausen]

Nice work! I added a test for the whole building schedule option to the tests.