Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore 0.5 maximum reheat flow fraction #1574

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

mdahlhausen
Copy link
Collaborator

No description provided.

@lymereJ
Copy link
Collaborator

lymereJ commented Aug 15, 2023

What were the diffs that triggered changes in the performance tests results?

@mdahlhausen
Copy link
Collaborator Author

mdahlhausen commented Aug 15, 2023

@lymereJ

Previously, as of the last release, Outpatient and Primary School 90.1-2010, 2013, 2016, and 2019 models were defaulting the terminals to 'autosize':
https://github.com/NREL/openstudio-standards/blob/v0.4.0/test/doe_prototype/regression_models/PrimarySchool-90.1-2016-ASHRAE%20169-2013-4A_expected_result.osm#L14151

This PR updates them to 0.5 (presumably as intended, according to the .idf versions of the PNNL prototypes):
https://github.com/NREL/openstudio-standards/blob/fix/default_vav_controls/test/doe_prototype/regression_models/PrimarySchool-90.1-2016-ASHRAE%20169-2013-4A_expected_result.osm#L14151

The last vav PR also included the air loop name in the Controller:OutdoorAir object instead of using default naming. That has no performance implications.

@lymereJ
Copy link
Collaborator

lymereJ commented Aug 15, 2023

@lymereJ

Previously, as of the last release, Outpatient and Primary School 90.1-2010, 2013, 2016, and 2019 models were defaulting the terminals to 'autosize': https://github.com/NREL/openstudio-standards/blob/v0.4.0/test/doe_prototype/regression_models/PrimarySchool-90.1-2016-ASHRAE%20169-2013-4A_expected_result.osm#L14151

That's right, I forgot that the PR fixed that. All good then!

@mdahlhausen mdahlhausen merged commit 13a79e8 into master Aug 16, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/default_vav_controls branch August 16, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants