Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sizing methods #1582

Merged
merged 25 commits into from
Sep 7, 2023
Merged

Remove sizing methods #1582

merged 25 commits into from
Sep 7, 2023

Conversation

mdahlhausen
Copy link
Collaborator

This removes the contents of the hvac_sizing directory.

Nearly all of these methods were implement in OpenStudio version 3.6.0. I added a version check in standards to error if the user is using an earlier version of OpenStudio.

There were two changes I'm not quite sure about.

  • @weilixu @lymereJ I deleted the prm overload of the plant_loop_total_cooling_capacity method. I sent an email about it. It is implemented as it's own commit so we can revert if needed.
  • Fan power lookups. Is it ok to just use the calculated method, rather than relying on the sqlFile tables?

remove Siz.AirLoopHVAC.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
remove Siz.CoilCoolingWater.rb and associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0.
remove Siz.HVACComponent.rb and associated methods. Only water heaters were using the feature. May consider generalizing if other components need it in the future.
remove Siz.HeatingCoolingFuels.rb and Siz.ThermalZone.rb and refactor associated methods. These methods are now available in OpenStudio as of OpenStudio version 3.6.0, under coolingFuelTypes, heatingFuelTypes, and appGHeatingFuelTypes
plant_loop_total_cooling_capacity is overloaded in the prm code and doesn't need to be
calculate fan power from existing field rather than relying on an sql file lookup
remove getAutosizedValueFromEquipmentSummary method from Siz.Model.rb
remove output fan report, which was only used for manually checking the older prm method
delete Siz.Model.rb and hvac_sizing directory
Copy link
Collaborator

@weilixu weilixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matt. This seems to be a significant lift and I appreciate you taking care of the PRM routine.
One general question - does OpenStudio::Error log message raise exceptions? There are several places I think we should either handle through an exception raise or adding an else statement

@mdahlhausen
Copy link
Collaborator Author

Making a note that this PR removes a method that creates a csv report of fans in the model and their properties
We may add this back in as a utility function at some point to get output fan variables.

# Helper function to output the fan power for each fan in the model
# @param [String] csv_path: if given, will output a csv file
# @return [Array of Hash] each row is a fan, with its name, type, rated watts per cfm, and the airloop or hvac component or zonehvac component it serves
# @todo output actual bhp and allowable bhp for systems 3-4 and 5-8
# @todo remove maybe later?
def output_fan_report(csv_path = nil)

@mdahlhausen mdahlhausen merged commit 4d4da95 into master Sep 7, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the remove_sizing_methods branch September 7, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants