Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extension gem #1602

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Feature/extension gem #1602

merged 10 commits into from
Sep 15, 2023

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Sep 13, 2023

Pull request overview

Adds the contents of OsLib_Schedules and the create typical methods in OsLib_ModelGeneration to openstudio-standards modules

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

move OsLib_Schedules methods from the openstudio-extension-gem to openstudio-standards.
Add tests for the new methods.
switch to object methods
add yard documentation edits
- remove references to runner and Os_Lib_HelperMethods
- add tests
@mdahlhausen mdahlhausen merged commit 9faa678 into master Sep 15, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the feature/extension_gem branch September 18, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant