Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing input limits to curves #1613

Merged
merged 2 commits into from
Sep 27, 2023
Merged

adds missing input limits to curves #1613

merged 2 commits into from
Sep 27, 2023

Conversation

eringold
Copy link
Collaborator

@eringold eringold commented Sep 26, 2023

Pull request overview

Adds missing curve input limits.

Pull Request Author

  • Data changes or additions

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!
I'm glad the fix was easier than anticipated.

I added make in a refrigeration curve that was removed in the initial commit. I'll merge once the tests pass.

@eringold
Copy link
Collaborator Author

Thanks for catching that deleted curve. Dont know how that happened...

@mdahlhausen
Copy link
Collaborator

Thanks for catching that deleted curve. Dont know how that happened...

That's why we have a CI!

@mdahlhausen mdahlhausen merged commit eebae6a into master Sep 27, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/curve_limits branch September 27, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Curves with missing independent variable min/max limits create unrealistic curves and equipment performance
2 participants