Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/extension gem merge #1619

Merged
merged 35 commits into from
Oct 11, 2023
Merged

Feature/extension gem merge #1619

merged 35 commits into from
Oct 11, 2023

Conversation

mdahlhausen
Copy link
Collaborator

Pull request overview

Merges the remainder of the openstudio-extension-gem into openstudio-standards.

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

mdahlhausen and others added 30 commits September 21, 2023 16:48
@mdahlhausen
geometry method updates
efa8b4d
@mdahlhausen
change typical_building_from_model to create_typical_building_from_model
efd34ee
@mdahlhausen
syntax to add _get to methods that return values
a36d45e
@mdahlhausen
rubocop edits
1ffe484
@mdahlhausen
OsLib_Geometry methods
7832d63
@mdahlhausen
Update create_bar.rb
6f617ba
@mdahlhausen
snake case sch variable names
ec024d1
@mdahlhausen
add create geometry tests
2ae5fd6
@eringold
remove double call to add_internal_mass
f9413d2
@eringold
move add_internal_mass after tstat creation
31b1fbf
@mdahlhausen
add cbecs hvac
d5be65d
@mdahlhausen
add constructions module
c6c3138
@mdahlhausen
add geometry tests
afd6ff7
@mdahlhausen
rename circleci_tests to ci_tests
c3aae3b
@mdahlhausen
move module tests to test/modules
2c77d9e
@mdahlhausen
add module tests to ci_tests
678d70e
@mdahlhausen
update path to minitest helper
e9945da
@mdahlhausen
fix module tests
8c3c388
@mdahlhausen
hash look typo fix
92f368c
@mdahlhausen
add space type blending methods and tests
ddc0921
@mdahlhausen
replace TODO with @todo
9195bc8
@mdahlhausen
add DEER enumerations
7e10d48
@mdahlhausen
add schedule_ruleset_get_start_and_end_times
0e847e3 
also fix test class names
@mdahlhausen
rubocop edits
2c07d6d
@mdahlhausen
add qaqc methods
88b6a5e
@mdahlhausen
fix typos
12cfe90
@mdahlhausen
add part load ratio qaqc check
da09a1d
@mdahlhausen
add qaqc test
0fca84f
@mdahlhausen
Merge branch 'master' into feature/extension_gem_merge
df0485f
@mdahlhausen
add check that sql file is available
ad936d9
@mdahlhausen mdahlhausen merged commit 0cabb31 into master Oct 11, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the feature/extension_gem_merge branch October 11, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGoldwasser DavidGoldwasser DavidGoldwasser approved these changes

@eringold eringold eringold approved these changes

@asparke2 asparke2 Awaiting requested review from asparke2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdahlhausen @DavidGoldwasser @eringold