Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS 3.7.0 release fixes #1621

Merged
merged 4 commits into from
Oct 13, 2023
Merged

OS 3.7.0 release fixes #1621

merged 4 commits into from
Oct 13, 2023

Conversation

mdahlhausen
Copy link
Collaborator

Pull request overview

Fixes issues from the OpenStudio develop image for the OS v3.7.0 release

Pull Request Author

  • Method changes or additions
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit c63bbf2 into master Oct 13, 2023
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/os_3_7_release branch October 13, 2023 16:36
@mdahlhausen mdahlhausen changed the title fixes for OS 3.7.0 release OS 3.7.0 release fixes Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdahlhausen