Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate hash assignment for QSR geometry #1625

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove duplicate hash assignment for QSR geometry #1625

merged 1 commit into from
Oct 19, 2023

Conversation

mdahlhausen
Copy link
Collaborator

Pull request overview

remove duplicate ratio lookup for create_bar

Pull Request Author

  • Data changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 26b2a03 into master Oct 19, 2023
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/remove_duplicate_qsr_wwr branch October 19, 2023 16:20
@mdahlhausen mdahlhausen changed the title remove duplicate hash assignment Remove duplicate hash assignment for QSR geometry Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdahlhausen