Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue cleanup for 2.0.0 release, part 1 #215

Merged
merged 10 commits into from Oct 13, 2020
Merged

Conversation

kandersolar
Copy link
Member

  • Code changes are covered by tests
  • New functions added to __init__.py no new functions
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

Old issue cleanup for 2.0.0. This addresses #191, #114, and #198.

For #114, I tested each pandas release from 0.23.2 to 1.0.0 and the only one with the issue was 0.24.0. Rather than bump the minimum version, I just excluded that specific version.

The complexity of the deprecation machinery is worth it IMHO -- it automatically modifies docstrings with a deprecation message, which then shows up in IDEs as well as propagating to the sphinx docs:

image


image


image

@kandersolar kandersolar added this to the Version 2 milestone Oct 13, 2020
Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kandersolar kandersolar merged commit a1a570a into development Oct 13, 2020
@kandersolar kandersolar deleted the 2.0.0_fixes_anderson branch October 13, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants