Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pvlib 0.9.x #290

Merged
merged 9 commits into from Sep 3, 2021
Merged

Support pvlib 0.9.x #290

merged 9 commits into from Sep 3, 2021

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Sep 2, 2021

  • Code changes are covered by tests
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

Extra to-do:

  • Add note to SAPM functions saying an older pvlib is needed

pvlib==0.9.0 is up on pypi as of today. Our current setup.py specifies 'pvlib >= 0.7.0, <0.9.0', but it'd be nice to support the 0.9.x series if it's easy. I think there are only two relevant changes (but we'll see what the CI has to say):

  • The SAPM normalization functionality won't work on 0.9.0 because LocalizedPVSystem is removed
  • For clear-sky modeling, the tables dependency is removed and h5py is added in its place. Note that h5py is required for pvlib 0.9.0 whereas tables was optional for previous versions.

@kandersolar kandersolar changed the base branch from development to release_2.1.0 September 3, 2021 18:31
Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment on lines -59 to -60
'pandas==0.23.0',
'pvlib==0.7.1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reasoning for removing these? Redundant with requirements.txt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[doc] is the requirements to build the sphinx docs, which doesn't actually require any rdtools functionality (e.g. make html does not run the notebooks or tests or anything). So no need to pin specific versions since the packages don't get used for building the docs anyway. And if we're not pinning versions then they're redundant with INSTALL_REQUIRES.

@mdeceglie mdeceglie merged commit aa5d8d3 into release_2.1.0 Sep 3, 2021
@mdeceglie mdeceglie deleted the pvlib_compat branch September 3, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants