Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/local pipeline #25

Merged
merged 8 commits into from
Oct 7, 2019
Merged

Gb/local pipeline #25

merged 8 commits into from
Oct 7, 2019

Conversation

grantbuster
Copy link
Member

No description provided.

Copy link
Collaborator

@MRossol MRossol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor style change and one question:

Where are the local vs Eagle jobs submitted? Did that not get changed? Is that not in Status.add_job?

reV/generation/generation.py Outdated Show resolved Hide resolved
@grantbuster
Copy link
Member Author

Where are the local vs Eagle jobs submitted? Did that not get changed? Is that not in Status.add_job?

The submit from config methods in the CLI's determine if a local job or an eagle job gets submitted. Everything past the CLI gets run as if on Local. Status.add_job only adds the job meta data to the status json, it does not submit work.

@MRossol
Copy link
Collaborator

MRossol commented Oct 7, 2019

Ready to merge assuming your rebased and docs are updated

@grantbuster grantbuster merged commit 3ece306 into master Oct 7, 2019
@grantbuster grantbuster deleted the gb/local_pipeline branch October 7, 2019 16:43
@MRossol MRossol mentioned this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants