Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Verbose Least Cost Path Out of Domain Error #129

Closed
MRossol opened this issue Aug 25, 2021 · 1 comment
Closed

More Verbose Least Cost Path Out of Domain Error #129

MRossol opened this issue Aug 25, 2021 · 1 comment
Labels
feature New feature or request

Comments

@MRossol
Copy link
Collaborator

MRossol commented Aug 25, 2021

Why this feature is necessary:
Currently offshore + Canada + Mexico are given a base cost of -1

A possible solution is:
Use custom regions to specify -1 for offshore and np.inf for out of domain, then check start and end values and raise appropriate error

Charge code
TBD

Urgency / Timeframe
TBD
@MRossol MRossol added the feature New feature or request label Aug 25, 2021
@MRossol
Copy link
Collaborator Author

MRossol commented Sep 13, 2021

implemented in #130

@MRossol MRossol closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MRossol