Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwarg to run Temporal Aggregation in local time instead of UTC #136

Open
MRossol opened this issue Oct 28, 2021 · 0 comments
Open

Kwarg to run Temporal Aggregation in local time instead of UTC #136

MRossol opened this issue Oct 28, 2021 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@MRossol
Copy link
Collaborator

MRossol commented Oct 28, 2021

Why this feature is necessary:
Dylan Harrison-Atlas is using the Temporal Aggregation Module to aggregate wind and solar CF profiles to daily values. The code is currently written to do the aggregation in UTC but he needs the ability to aggregate each site in local time.

A possible solution is:

  1. add a boolean kwarg local_time to the class
  2. Update the _aggregate_sites method to roll the timeseries to local time before creating the DataFrame (specifically modify line 129).

Additional context
NOTE: Its probably worth it to add in logic to determine if all sites in a given chunk have the same timezone or not as the later (not) case will require different logic to roll different sites different amounts. I know I've tried to do this before and can't remember what the solution was....

Charge code
GMLC.10246.09.05.03

Urgency / Timeframe
11/12/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants