Merge pull request #1108 from NREL/buildreshpxml_cfa_served

Test OS-HPXML 1141

resources/hpxml-measures/BuildResidentialHPXML/measure.rb

@@ -5110,7 +5110,16 @@ def self.set_ducts(args, hvac_distribution)
 
     # If duct surface areas are defaulted, set CFA served
     if hvac_distribution.ducts.select { |d| d.duct_surface_area.nil? }.size > 0
-      hvac_distribution.conditioned_floor_area_served = args[:geometry_unit_cfa]
+      max_fraction_load_served = 0.0
+      hvac_distribution.hvac_systems.each do |hvac_system|
+        if hvac_system.respond_to?(:fraction_heat_load_served)
+          max_fraction_load_served = [max_fraction_load_served, hvac_system.fraction_heat_load_served].max
+        end
+        if hvac_system.respond_to?(:fraction_cool_load_served)
+          max_fraction_load_served = [max_fraction_load_served, hvac_system.fraction_cool_load_served].max
+        end
+      end
+      hvac_distribution.conditioned_floor_area_served = args[:geometry_unit_cfa] * max_fraction_load_served
     end
   end
 

resources/hpxml-measures/BuildResidentialHPXML/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>build_residential_hpxml</name>
   <uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
-  <version_id>88fef79c-0316-4d9a-bd2a-20c5e8cfa794</version_id>
-  <version_modified>2023-07-14T15:38:31Z</version_modified>
+  <version_id>7106e0ea-76b6-4905-9570-1aee1a32f1b1</version_id>
+  <version_modified>2023-07-18T23:32:03Z</version_modified>
   <xml_checksum>2C38F48B</xml_checksum>
   <class_name>BuildResidentialHPXML</class_name>
   <display_name>HPXML Builder</display_name>
@@ -6691,7 +6691,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>86A85792</checksum>
+      <checksum>F78D40DC</checksum>
     </file>
     <file>
       <filename>geometry.rb</filename>

resources/hpxml-measures/Changelog.md

@@ -16,6 +16,7 @@ __Bugfixes__
 - Fixes error if heat pump `CompressorLockoutTemperature` == `BackupHeatingLockoutTemperature`.
 - Fixes possible "Electricity category end uses do not sum to total" error for a heat pump w/o backup.
 - Fixes error if conditioned basement has `InsulationSpansEntireSlab=true`.
+- BuildResidentialHPXML measure: Fixes air distribution CFA served when there is not a central system that meets 100% of the load.
 
 ## OpenStudio-HPXML v1.6.0
 

resources/hpxml-measures/docs/source/workflow_inputs.rst

@@ -334,7 +334,7 @@ If EmissionsType is "CO2e", "NOx" or "SO2" and a given fuel's emissions factor i
   wood pellets  --              --             --
   ============  ==============  =============  =============
 
-Default values in lb/MBtu (million Btu) are from *Table 5.1.2(1) National Average Emission Factors for Household Fuels* from *ANSI/RESNET/ICCC 301 Standard for the Calculation and Labeling of the Energy Performance of Dwelling and Sleeping Units using an Energy Rating Index* and include both combustion and pre-combustion (e.g., methane leakage for natural gas) emissions.
+Default values in lb/MBtu (million Btu) are from *Table 5.1.2(1) National Average Emission Factors for Household Fuels* from *ANSI/RESNET/ICC 301 Standard for the Calculation and Labeling of the Energy Performance of Dwelling and Sleeping Units using an Energy Rating Index* and include both combustion and pre-combustion (e.g., methane leakage for natural gas) emissions.
 
 If no default value is available, a warning will be issued.
 
@@ -2216,7 +2216,7 @@ Additional information is entered in each ``Ducts``.
          See :ref:`hpxmllocations` for descriptions.
   .. [#] If DuctLocation not provided, defaults to the first present space type: "basement - conditioned", "basement - unconditioned", "crawlspace - conditioned", "crawlspace - vented", "crawlspace - unvented", "attic - vented", "attic - unvented", "garage", or "living space".
          If NumberofConditionedFloorsAboveGrade > 1, secondary ducts will be located in "living space".
-  .. [#] The sum of all ``[DuctType="supply"]/FractionDuctArea`` and ``[DuctType="return"]/FractionDuctArea`` must each equal to 1.
+  .. [#] The sum of all ``FractionDuctArea`` must each equal to 1, both for the supply side and return side.
   .. [#] FractionDuctArea and/or DuctSurfaceArea are required if DuctLocation is provided.
   .. [#] | If neither DuctSurfaceArea nor FractionDuctArea provided, duct surface areas will be calculated based on `ASHRAE Standard 152 <https://www.energy.gov/eere/buildings/downloads/ashrae-standard-152-spreadsheet>`_:
          | - **Primary supply duct area**: 0.27 * F_out * ConditionedFloorAreaServed

resources/hpxml-measures/tasks.rb

@@ -72,7 +72,7 @@ def create_hpxmls
     end
 
     if not success
-      puts "\nError: Did not successfully generate #{hpxml_file}."
+      puts "\nError: Did not successfully generate #{hpxml_filename}."
       exit!
     end
 

resources/hpxml-measures/workflow/hpxml_inputs.json

@@ -2262,6 +2262,17 @@
     "ducts_return_buried_insulation_level": "deeply buried",
     "ducts_return_insulation_r": 4
   },
+  "sample_files/base-hvac-ducts-defaults.xml": {
+    "parent_hpxml": "sample_files/base-hvac-furnace-gas-room-ac.xml",
+    "heating_system_fraction_heat_load_served": 0.75,
+    "heating_system_2_type": "Fireplace",
+    "heating_system_2_heating_efficiency": 1.0,
+    "heating_system_2_fraction_heat_load_served": 0.25,
+    "ducts_supply_location": null,
+    "ducts_supply_surface_area": null,
+    "ducts_return_location": null,
+    "ducts_return_surface_area": null
+  },
   "sample_files/base-hvac-ducts-effective-rvalue.xml": {
     "parent_hpxml": "sample_files/base.xml"
   },