Skip to content

Commit

Permalink
Merge pull request #1149 from NREL/bsb-version-and-update-rtd
Browse files Browse the repository at this point in the history
Fix docs again, Gem::Version on bsb version strings
  • Loading branch information
joseph-robertson committed Oct 18, 2023
2 parents 5ab9e3c + ba65875 commit e2b9bee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ version: 2
sphinx:
configuration: docs/read_the_docs/source/conf.py

build:
os: "ubuntu-22.04"
tools:
python: "3.11"

python:
version: "3.8"
install:
- requirements: docs/read_the_docs/requirements.txt
2 changes: 1 addition & 1 deletion resources/buildstock.rb
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ class Version
def self.check_buildstockbatch_version
if ENV.keys.include?('BUILDSTOCKBATCH_VERSION') # buildstockbatch is installed
bsb_version = ENV['BUILDSTOCKBATCH_VERSION']
if bsb_version < BuildStockBatch_Version
if Gem::Version.new(bsb_version) < Gem::Version.new(BuildStockBatch_Version)
fail "BuildStockBatch version #{BuildStockBatch_Version} or above is required. Found version: #{bsb_version}"
end
end
Expand Down

0 comments on commit e2b9bee

Please sign in to comment.