Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make after switching to ResStock-HPXML #731

Closed
12 of 13 tasks
joseph-robertson opened this issue Oct 25, 2021 · 3 comments · Fixed by #856
Closed
12 of 13 tasks

Changes to make after switching to ResStock-HPXML #731

joseph-robertson opened this issue Oct 25, 2021 · 3 comments · Fixed by #856
Assignees
Projects

Comments

@joseph-robertson
Copy link
Contributor

joseph-robertson commented Oct 25, 2021

Checklist:

  • [Andrew] Remove test/column_mapping.csv file and reference in test/compare.py (perhaps convert it to a template so we can support future output name changes?)
  • [Joe] Remove python test/compare.py -m feature from config.yml
  • [Joe] project_testing/Schedules.tsv to equal distribution of Default and Stochastic https://github.com/NREL/resstock-estimation/pull/187
  • [Joe] project_testing/HVAC System Is Faulted.tsv to equal distribution of No and Yes https://github.com/NREL/resstock-estimation/pull/192
  • [Joe] Add finished attic options back into project_national (and update options_lookup.tsv to actually model finished attics?) Model conditioned/finished attics #820
  • [Joe] Enable rim joists (set this by default, and r-value to foundation wall r-value); we could potentially enable rim joists between floors by adjusting average ceiling height, but we won't for now
  • [Andrew] Remove tsv that combines wall type and exterior finish https://github.com/NREL/resstock-estimation/pull/190
  • Automate creation of tsv files with commented out method calls; low priority; wait for RECS 2020 updates
  • Clean up README.md:
    • "... arguments into OpenStudio Measures"
    • two references for OpenStudio Measures
    • "ongoing" EULP project
  • [Joe] Change timeseries in base_results back to kWh, kBtu (from MBtu) Retain original timeseries units #841
@joseph-robertson joseph-robertson added this to Work on hold/Waiting on others in resstock Oct 25, 2021
@shorowit
Copy link
Contributor

shorowit commented Jan 27, 2022

There are a bunch of option names that should be changed after the switch too. The old names from develop are still being used on restructure for comparison purposes, but some of them are wrong or misleading. Some examples:

  • [Joe] Natural Ventilation: "Year-Round, 3 days/wk" => "Cooling Season, 7 days/wk"
  • [Joe] Hot Water Distribution: There is no differentiation between Copper vs PEX or HomeRun vs TrunkBranch. Remove some options and rename all of them.

There may be others, I'm just documenting the ones I came across recently.

@aspeake
Copy link
Contributor

aspeake commented Feb 2, 2022

ceiling_assembly_r and floor_over_garage_assembly_r are non-zero for the None options of Insulation Ceiling and Insulation Floor to avoid hitting errors with finished attics and homes with floors above garages. These should both be set to 0, but some changes will be needed to do so:

  • [Andrew] After updating the finished attic options, set ceiling_assembly_r = 0 for the None Insulation Ceiling option Model finished attics #830

-[ ] [Andrew] Rework Insulation Floor.tsv so that no dependencies have a None option, and instead the value would apply to any applicable frame floors (ie, floors over garages). Set floor_over_garage_assembly_r = 0 for the None Insulation Floor option Created a new issue: https://github.com/NREL/resstock-estimation/issues/277

@shorowit
Copy link
Contributor

shorowit commented Feb 8, 2022

  • [Joe] Update documentation, README, etc.
  • [Phil?] Review documentation

@joseph-robertson joseph-robertson moved this from Work on hold/Waiting on others to In progress in resstock Feb 10, 2022
@joseph-robertson joseph-robertson mentioned this issue Feb 11, 2022
5 tasks
resstock automation moved this from In progress to Done Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants