Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rim joists #831

Merged
merged 30 commits into from Feb 17, 2022
Merged

Enable rim joists #831

merged 30 commits into from Feb 17, 2022

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Feb 11, 2022 •
edited

Pull Request Description

Addresses #731.

image

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected integration/regression test changes

@joseph-robertson joseph-robertson added this to In progress in resstock via automation Feb 11, 2022
@joseph-robertson joseph-robertson self-assigned this Feb 11, 2022
aspeake
aspeake reviewed Feb 14, 2022
View reviewed changes
resources/options_lookup.tsv Outdated Show resolved Hide resolved
workflow/run_analysis.rb Outdated Show resolved Hide resolved
@joseph-robertson joseph-robertson merged commit 841018b into develop Feb 17, 2022
resstock automation moved this from In progress to Done Feb 17, 2022
@joseph-robertson joseph-robertson deleted the enable-rim-joists branch February 17, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

@aspeake aspeake aspeake approved these changes

Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
No open projects
resstock
Done
Milestone
ResStock v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joseph-robertson @shorowit @aspeake