-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOI Report peak kW conversion inconsistency? #886
Comments
Is the solution here to:
|
Note that the OS-HPXML reporting measure produces summer/winter peak electricity outputs. |
Do (A) and (B) basically give the same answer, but (B) is slower? |
I think (A) and (B) could theoretically give different results. Consider the following example for kWh during the first 2 hours: Hourly: 0.75, 1 Then kW would be: Hourly: 0.75, 1 Hourly would assign peak at hour 2, while 15-minutely would assign peak at hour 1. |
Leaning toward just calculating based on hourly timeseries. Which means the PR goes away, and we just need to hardcode |
Some of the QOIReport measure outputs could probably be adopted into the OS-HPXML workflow (where we might also be able to avoid getting timeseries output). |
@joseph-robertson Would this mean you can't run ResStock with a 15-min timestep, or is the hardcoding just for the reporting measure? |
Just for the reporting measure. |
The peak kW seem results seem to be high. The query (line 185) has
ReportingFrequency='Hourly'
, but I think it should beReportingFrequency='Timestep'
as the unit conversion step (line 195) includes the number of timesteps per hour. I think there might be a 4x difference in the results.resstock/measures/QOIReport/measure.rb
Lines 185 to 195 in e0050be
The text was updated successfully, but these errors were encountered: