add Duct Location and Duct Leakage to Outside #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 413c5ff.
shorowit
reviewed
Jul 24, 2023
…d1488aa 704f0d1488aa Merge pull request #1455 from NREL/buildreshpxml_duct_fractions git-subtree-dir: resources/hpxml-measures git-subtree-split: 704f0d1488aa0770b46b159a6a1904917520821b
add Duct Location and Duct Leakage to Outside, try 2
joseph-robertson
requested review from
joseph-robertson
and removed request for
rajeee and
afontani
joseph-robertson
approved these changes
Aug 9, 2023
| @@ -354,3 +341,16 @@ jobs: | |||
| echo "Pushing to branch: $branch_name" | |||
| git push -u origin $branch_name | |||
| fi | |||
|
|
|||
| - name: Build documentation | |||
There was a problem hiding this comment.
Not sure why these 2 docs steps got moved down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves Issue #1095
Companion resstock-estimation PR: https://github.com/NREL/resstock-estimation/pull/377/
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run