TSV changes from prune_rules refactor and adding options_saturations.csv #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeee
changed the title
afontani
approved these changes
Sep 6, 2023
| @@ -8,7 +8,7 @@ Not all may apply: | |||
|
|
|||
| - [ ] Tests (and test files) have been updated | |||
| - [ ] Documentation has been updated | |||
| - [ ] If related to resstock-estimation, checklist includes [data dictionary](https://github.com/NREL/resstock/tree/develop/resources/data/dictionary), [source report](https://github.com/NREL/resstock/tree/develop/project_national/resources/source_report.csv), [options_lookup](https://github.com/NREL/resstock/blob/develop/resources/options_lookup.tsv). | |||
| - [ ] If related to resstock-estimation, checklist includes [data dictionary](https://github.com/NREL/resstock/tree/develop/resources/data/dictionary), [source report](https://github.com/NREL/resstock/tree/develop/project_national/resources/source_report.csv), [options saturation](https://github.com/NREL/resstock/tree/develop/project_national/resources/options_saturations.csv), [options_lookup](https://github.com/NREL/resstock/blob/develop/resources/options_lookup.tsv). | |||
| @@ -5,6 +5,7 @@ Features | |||
| - Update characteristics to use EIA 2020 RECS ([#1031](https://github.com/NREL/resstock/pull/1031)) | |||
| - Include HVAC secondary heating capabilities for project_testing ([#1090](https://github.com/NREL/resstock/pull/1090)) | |||
| - For heat pump upgrades, adds the ability to set the existing primary (non-shared) heating system as the backup system using only a single option from the lookup ([#1074](https://github.com/NREL/resstock/pull/1074)) | |||
| - options_saturations.csv is added to project_*/resources/ folder. | |||
There was a problem hiding this comment.
- oops, forgot the link. Okay to push that directly to develop or would you like a PR?
| @@ -0,0 +1,12381 @@ | |||
| Level,Parameter,Option,Saturation | |||
There was a problem hiding this comment.
Is this file just supplemental information, from the perspective of a resstock user? Should it be rendered somehow, or at least referenced, from the docs?
There was a problem hiding this comment.
This is supplemental information. It could be rendered in the docs like how the source_report is rendered but that's optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Companion PR to https://github.com/NREL/resstock-estimation/pull/386
Also add options_saturations.csv to resources.
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run