Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up #1145

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Minor clean-up #1145

merged 4 commits into from
Oct 13, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Oct 10, 2023

Pull Request Description

Items:

  • Remove empty resstock-measures README; remove LICENSE; planned to connect measures folder to separate repo at one point in time, but that never happened.
  • Remove extra stuff around heat_pump_backup_use_existing_system in ResStockArguments and ApplyUpgrade; turns out this is not needed because we are reading heat_pump_backup_use_existing_system from the measures hash and not from new_runner.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson joseph-robertson added this to the ResStock v3.2.0 milestone Oct 10, 2023
@joseph-robertson joseph-robertson self-assigned this Oct 10, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review October 12, 2023 20:39
@joseph-robertson joseph-robertson merged commit 5ab9e3c into develop Oct 13, 2023
7 checks passed
@joseph-robertson joseph-robertson deleted the minor-issues branch October 13, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant