Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old HPWH options from options_lookup #1190

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Remove old HPWH options from options_lookup #1190

merged 2 commits into from
Jan 12, 2024

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Jan 11, 2024 •
edited

Pull Request Description

Removing the old HPWH options from options_lookup.tsv

Closes #1184

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

jmaguire1
jmaguire1 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tony! Looks good

@afontani afontani merged commit 984ff0e into develop Jan 12, 2024
7 checks passed
@afontani afontani mentioned this pull request Feb 12, 2024
Merged
4 tasks
@joseph-robertson joseph-robertson deleted the remove_old_hpwh_options branch April 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaguire1 jmaguire1 jmaguire1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove legacy HPWH options
2 participants
@afontani @jmaguire1