-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HVAC autosizing and add/replace fixes #263
Conversation
joseph-robertson
commented
May 31, 2019
•
edited
Loading
edited
- When a model has both a central system and non central system, don't autosize the non central system (e.g., central boiler with room ac)
- Cannot have heating-only fan coil anymore; the ZoneHVACUnitHeater object was not being autosized correctly and was resulting in zero heating energy
- Don't remove the cooling-only fan coil when applying a heating-only non central system (e.g., cooling-only fan coil with furnace)
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 93.13% 93.11% -0.03%
==========================================
Files 165 165
Lines 47686 47672 -14
==========================================
- Hits 44413 44389 -24
- Misses 3273 3283 +10
Continue to review full report at Codecov.
|
|
|
Regression tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joseph-robertson Thanks for catching these bugs. I have looked at the scenarios that apply to the LA projects, and the number of "shared" systems is not that large. As a result, the scenarios that these situations should show up in these projects are also small.