Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVAC autosizing and add/replace fixes #263

Merged
merged 11 commits into from
Jun 6, 2019
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented May 31, 2019

  • When a model has both a central system and non central system, don't autosize the non central system (e.g., central boiler with room ac)
  • Cannot have heating-only fan coil anymore; the ZoneHVACUnitHeater object was not being autosized correctly and was resulting in zero heating energy
  • Don't remove the cooling-only fan coil when applying a heating-only non central system (e.g., cooling-only fan coil with furnace)

@joseph-robertson joseph-robertson self-assigned this May 31, 2019
@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #263 into master will decrease coverage by 0.02%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   93.13%   93.11%   -0.03%     
==========================================
  Files         165      165              
  Lines       47686    47672      -14     
==========================================
- Hits        44413    44389      -24     
- Misses       3273     3283      +10
Impacted Files Coverage Δ
...urces/measures/HPXMLtoOpenStudio/resources/util.rb 63.08% <0%> (-0.47%) ⬇️
...Baseboard/tests/process_electric_baseboard_test.rb 100% <100%> (ø) ⬆️
...alHVACUnitHeater/tests/process_unit_heater_test.rb 99.56% <100%> (ø) ⬆️
...ocess_single_speed_central_air_conditioner_test.rb 100% <100%> (ø) ⬆️
...s/process_central_system_boiler_baseboards_test.rb 100% <100%> (ø) ⬆️
...cess_ground_source_heat_pump_vertical_bore_test.rb 99.7% <100%> (ø) ⬆️
...sidentialHVACFurnace/tests/process_furnace_test.rb 100% <100%> (ø) ⬆️
...Coil/tests/process_central_system_fan_coil_test.rb 91.8% <100%> (-8.2%) ⬇️
...itioner/tests/process_room_air_conditioner_test.rb 100% <100%> (ø) ⬆️
.../process_single_speed_air_source_heat_pump_test.rb 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8013603...6cd30a9. Read the comment docs.

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented May 31, 2019

  • BoilerBaseboards + CentralAC/RoomAC: cooling comes way down, especially for CentralAC

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented May 31, 2019

  • Appears to be a bug where FanCoilHeatingOnly consumes no heating energy. I'm planning to send Jeff an idf to investigate.

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented May 31, 2019

Regression tests:

Copy link
Contributor

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-robertson Thanks for catching these bugs. I have looked at the scenarios that apply to the LA projects, and the number of "shared" systems is not that large. As a result, the scenarios that these situations should show up in these projects are also small.

@joseph-robertson joseph-robertson merged commit 014523b into master Jun 6, 2019
@joseph-robertson joseph-robertson deleted the autosize-fix branch June 6, 2019 19:26
@joseph-robertson joseph-robertson added this to the ResStock v2.1.0 milestone Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants